Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against null values #42 #43

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

johnatawnclementawn
Copy link
Member

Resolves #42

(This is following same pattern present in the concept-list datatype get_display_value method)

@jacobtylerwalls
Copy link
Member

A test would be nice (for the next person who comes along and wants to know how None is handled).

Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, tests look great.

@johnatawnclementawn johnatawnclementawn merged commit 9f4d0f3 into main Oct 17, 2024
5 checks passed
@johnatawnclementawn johnatawnclementawn deleted the jmc/42_guard_against_null_values branch October 17, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guard against null values in get_display_value
2 participants